feat: support last cycle prime summary modal by cuzz-venus · Pull Request #5630 · VenusProtocol/venus-protocol-interface

cuzz-venus · 2026-06-15T10:56:03Z

Jira ticket(s)

no tickets only want separate PR for cycle summary modal

Changes

add last cycle summary modal since need reuse total rewards card / user rewards card.

changeset-bot · 2026-06-15T10:56:07Z

⚠️ No Changeset found

Latest commit: bd2ecf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2026-06-15T10:56:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
dapp-preview	Ready	Preview	Jun 17, 2026 10:07am
dapp-testnet	Ready	Preview	Jun 17, 2026 10:07am
venus.io	Ready	Preview	Jun 17, 2026 10:07am

greptile-apps · 2026-06-15T10:59:44Z

Greptile Summary

This PR adds a LastCycleSummaryModal that reuses the existing TotalRewardsCard and UserRewardsCard components to display prior-cycle Prime reward data, and extracts a new PrimeRewardBadge component to avoid duplication. Both card components receive optional title and content/showMarketActions props to support a read-only summary context without breaking existing usages.

LastCycleSummaryModal wires together the two reward cards with last-cycle-specific titles and a conditional eligibility message; all data is currently placeholder with TODO comments marking where API integration will go.
TotalRewardsCard and UserRewardsCard are extended with optional props that fall back to existing behaviour when not provided, keeping the changes backward-compatible.
Seven locale files each receive a new lastCycleSummary translation block covering the modal title, card titles, and eligible/not-eligible messages.

Confidence Score: 5/5

Safe to merge; all changes are additive and the existing card components remain backward-compatible via optional props with sensible fallbacks.

The new modal is entirely placeholder-driven with explicit TODO comments, the component extensions use optional props that don't affect existing callers, and all translation keys are freshly added without touching existing ones. The two flagged items are design notes for the upcoming API integration pass, not defects in the current code.

LastCycleSummaryModal/index.tsx and UserRewardsCard/index.tsx will need attention when real API data replaces the placeholder constants.

Important Files Changed

Filename	Overview
apps/evm/src/pages/PrimeLeaderboard/LastCycleSummaryModal/index.tsx	New modal composing TotalRewardsCard and UserRewardsCard for last-cycle data; eligibility-message branch is unreachable because `placeholderHasRewards` is hardcoded to `true`
apps/evm/src/pages/PrimeLeaderboard/UserRewardsCard/index.tsx	Adds optional `title`, `content`, and `showMarketActions` props to enable reuse as a read-only summary; `apyPercentage` remains required in `UserMarketReward` even when `showMarketActions={false}` leaves it unused
apps/evm/src/pages/PrimeLeaderboard/TotalRewardsCard/index.tsx	Adds optional `title` prop with fallback to existing translation; clean, backward-compatible change
apps/evm/src/pages/PrimeLeaderboard/PrimeRewardBadge/index.tsx	New shared badge component extracted from UserRewardsCard; straightforward presentational component
apps/evm/src/pages/PrimeLeaderboard/LastCycleSummaryModal/tests/index.spec.tsx	Smoke test verifying modal title and both card titles render; only covers the `placeholderHasRewards=true` path — eligibility message branches have no test coverage
apps/evm/src/libs/translations/translations/en.json	Adds `lastCycleSummary` translation block; `eligibleMessage` uses "in this cycle" phrasing that contradicts the last-cycle modal context
apps/evm/src/libs/translations/translations/ja.json	Japanese translations for the new `lastCycleSummary` block
apps/evm/src/libs/translations/translations/th.json	Thai translations for the new `lastCycleSummary` block
apps/evm/src/libs/translations/translations/tr.json	Turkish translations for the new `lastCycleSummary` block
apps/evm/src/libs/translations/translations/vi.json	Vietnamese translations for the new `lastCycleSummary` block
apps/evm/src/libs/translations/translations/zh-Hans.json	Simplified Chinese translations for the new `lastCycleSummary` block
apps/evm/src/libs/translations/translations/zh-Hant.json	Traditional Chinese translations for the new `lastCycleSummary` block

_{Reviews (2): Last reviewed commit: "fix: solve comments" | Re-trigger Greptile}

greptile-apps · 2026-06-15T10:59:48Z

@@ -37,15 +45,15 @@ export const UserRewardsCard: React.FC<UserRewardsCardProps> = ({
      <div>


Hardcoded "this cycle" label shown in last cycle modal

UserRewardsCard always renders the title from t('primeLeaderboard.userRewards.title') ("Your Prime rewards this cycle"), but LastCycleSummaryModal uses this card to display last cycle data. Unlike TotalRewardsCard, which received a new optional title prop to allow overriding the default text, UserRewardsCard has no equivalent mechanism — so the label will always read "this cycle" even when embedded in the Last Cycle Summary Modal.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

github-actions · 2026-06-15T11:08:53Z

Coverage Report for ./apps/evm

Status	Category	Percentage	Covered / Total
🔵	Lines	81.66%	48097 / 58899
🔵	Statements	81.66%	48097 / 58899
🔵	Functions	62.58%	669 / 1069
🔵	Branches	72.91%	5458 / 7485

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
apps/evm/src/constants/prime.ts	99.08%	0%	100%	99.08%	1
apps/evm/src/pages/PrimeLeaderboard/EndOfCycle/index.tsx	100%	85.71%	66.66%	100%
apps/evm/src/pages/PrimeLeaderboard/LastCycleSummaryModal/index.tsx	100%	50%	100%	100%
apps/evm/src/pages/PrimeLeaderboard/LastCycleSummaryModal/UserRankCard/index.tsx	94.73%	0%	100%	94.73%	28-29
apps/evm/src/pages/PrimeLeaderboard/PrimeRewardBadge/index.tsx	0%	0%	0%	0%	1-17
apps/evm/src/pages/PrimeLeaderboard/TotalRewardsCard/index.tsx	100%	0%	100%	100%
apps/evm/src/pages/PrimeLeaderboard/UserRewardsCard/index.tsx	100%	85.71%	100%	100%

Generated in workflow #13656 for commit bd2ecf9 by the Vitest Coverage Report Action

cuzz-venus · 2026-06-15T13:42:49Z

@greptile review again

Replace the top total-rewards card with a user rank card that surfaces the user's last-cycle rank, Prime score and one of three outcome messages (qualified / missed top rank / not ranked), derived from the rank. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

The last cycle summary user rewards card now always shows the rewards amount (zero when none), so drop the eligibility content override and its translations that are no longer used there. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

therealemjy · 2026-06-17T13:01:28Z

+// Maximum rank that qualifies for Prime during a cycle
+export const PRIME_RANK_LIMIT = 500;


This should be fetched from the contract (it could change in the future through a VIP).

therealemjy · 2026-06-18T09:26:29Z

    },
+    "lastCycleSummary": {
+      "primeScoreLabel": "Prime score",
+      "rankLabel": "Your rank",


I mentioned this to Zed yesterday, this should be "You ranked". Sorry for the last minute change.

therealemjy · 2026-06-18T09:28:02Z

+      "rankMissed": "Almost there! You weren't in last cycle's top 500. Boost your stake to qualify this cycle.",
+      "rankNoStake": "You didn't stake XVS last cycle. Stake now to qualify for Prime and earn extra rewards.",
+      "rankQualified": "Congrats! You're in the Top 500 during last cycle and qualified for Prime Rewards.",


These weren't proof read I think.

Suggested change

"rankMissed": "Almost there! You weren't in last cycle's top 500. Boost your stake to qualify this cycle.",

"rankNoStake": "You didn't stake XVS last cycle. Stake now to qualify for Prime and earn extra rewards.",

"rankQualified": "Congrats! You're in the Top 500 during last cycle and qualified for Prime Rewards.",

"rankMissed": "Almost there! You weren't in the top 500 last cycle. Increase your stake to qualify this cycle.",

"rankNoStake": "You didn't stake XVS during the last cycle. Stake now to qualify for Prime in the next cycle and earn extra rewards.",

"rankQualified": "Congrats! You were in the top 500 during the last cycle and qualified for Prime rewards.",

greptile-apps Bot reviewed Jun 15, 2026

View reviewed changes

vercel Bot deployed to Preview – dapp-preview June 15, 2026 11:22 View deployment

vercel Bot deployed to Preview – venus.io June 15, 2026 11:22 View deployment

vercel Bot deployed to Preview – dapp-testnet June 15, 2026 11:22 View deployment

cuzz-venus force-pushed the feat/prime-total-rewards branch from 62bff1f to 4f5780c Compare June 16, 2026 06:58

cuzz-venus force-pushed the feat/prime-last-cycle-summary branch from edf37b3 to 0a149bb Compare June 16, 2026 06:58

vercel Bot deployed to Preview – dapp-preview June 16, 2026 07:00 View deployment

vercel Bot deployed to Preview – venus.io June 16, 2026 07:00 View deployment

vercel Bot deployed to Preview – dapp-testnet June 16, 2026 07:01 View deployment

vercel Bot deployed to Preview – dapp-preview June 16, 2026 08:16 View deployment

vercel Bot deployed to Preview – dapp-testnet June 16, 2026 08:16 View deployment

vercel Bot deployed to Preview – venus.io June 16, 2026 08:17 View deployment

cuzz-venus force-pushed the feat/prime-total-rewards branch from 7da6c3a to 2131c0f Compare June 16, 2026 10:01

cuzz-venus force-pushed the feat/prime-last-cycle-summary branch from 30026a2 to 4cd7e90 Compare June 16, 2026 10:01

vercel Bot deployed to Preview – dapp-testnet June 16, 2026 10:03 View deployment

vercel Bot deployed to Preview – venus.io June 16, 2026 10:03 View deployment

vercel Bot deployed to Preview – dapp-preview June 16, 2026 10:03 View deployment

vercel Bot deployed to Preview – dapp-preview June 17, 2026 04:45 View deployment

vercel Bot deployed to Preview – dapp-testnet June 17, 2026 04:45 View deployment

vercel Bot deployed to Preview – venus.io June 17, 2026 04:45 View deployment

cuzz-venus and others added 5 commits June 17, 2026 17:27

feat: support last cycle prime summary modal

0a7626e

fix: solve comments

0077259

feat: support last cycle modal open

ac5d3b9

cuzz-venus force-pushed the feat/prime-last-cycle-summary branch from c60f5ff to bd2ecf9 Compare June 17, 2026 10:05

vercel Bot deployed to Preview – dapp-testnet June 17, 2026 10:07 View deployment

vercel Bot deployed to Preview – venus.io June 17, 2026 10:07 View deployment

vercel Bot deployed to Preview – dapp-preview June 17, 2026 10:07 View deployment

cuzz-venus requested a review from therealemjy June 17, 2026 11:29

therealemjy reviewed Jun 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support last cycle prime summary modal#5630

feat: support last cycle prime summary modal#5630
cuzz-venus wants to merge 5 commits into
feat/prime-total-rewardsfrom
feat/prime-last-cycle-summary

cuzz-venus commented Jun 15, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Jun 15, 2026

Uh oh!

cuzz-venus Jun 15, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

cuzz-venus commented Jun 15, 2026

Uh oh!

therealemjy Jun 17, 2026

Uh oh!

therealemjy Jun 18, 2026

Uh oh!

therealemjy Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -37,15 +45,15 @@ export const UserRewardsCard: React.FC<UserRewardsCardProps> = ({
		<div>

		// Maximum rank that qualifies for Prime during a cycle
		export const PRIME_RANK_LIMIT = 500;

Conversation

cuzz-venus commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira ticket(s)

Changes

Uh oh!

changeset-bot Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

cuzz-venus Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for ./apps/evm

Uh oh!

cuzz-venus commented Jun 15, 2026

Uh oh!

therealemjy Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

therealemjy Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

therealemjy Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cuzz-venus commented Jun 15, 2026 •

edited

Loading

changeset-bot Bot commented Jun 15, 2026 •

edited

Loading

vercel Bot commented Jun 15, 2026 •

edited

Loading

greptile-apps Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading